Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Compute images create from image #4180

Merged
merged 4 commits into from
Jun 30, 2024

Conversation

BigBlackWolf
Copy link
Collaborator

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@BigBlackWolf BigBlackWolf requested review from a team as code owners June 11, 2024 10:34
Copy link

snippet-bot bot commented Jun 11, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 11, 2024
@BigBlackWolf BigBlackWolf changed the title Compute images create from image feat: Compute images create from image Jun 11, 2024
@BigBlackWolf BigBlackWolf added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@BigBlackWolf BigBlackWolf self-assigned this Jun 11, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 11, 2024
@BigBlackWolf BigBlackWolf added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 11, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2024
@BigBlackWolf BigBlackWolf requested a review from muncus June 13, 2024 11:18
@BigBlackWolf BigBlackWolf force-pushed the compute_images_create_from_image branch from 491382d to b535bac Compare June 14, 2024 08:21
@BigBlackWolf BigBlackWolf added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 14, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 14, 2024
@BigBlackWolf BigBlackWolf added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2024
@BigBlackWolf BigBlackWolf force-pushed the compute_images_create_from_image branch from b535bac to 3541e14 Compare June 17, 2024 10:06
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
muncus
muncus previously requested changes Jun 20, 2024
Copy link
Collaborator

@muncus muncus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice reuse of the GetDiskImageFromFamily method 👍🏼

compute/disk-images/disk_image_test.go Outdated Show resolved Hide resolved
compute/disk-images/create_disk_from_image.go Outdated Show resolved Hide resolved
compute/disk-images/disk_image_test.go Outdated Show resolved Hide resolved
@BigBlackWolf BigBlackWolf added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 21, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 21, 2024
@BigBlackWolf BigBlackWolf requested a review from muncus June 22, 2024 08:19
@BigBlackWolf BigBlackWolf enabled auto-merge (squash) June 27, 2024 10:45
@BigBlackWolf BigBlackWolf requested a review from a team as a code owner June 28, 2024 15:41
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 28, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2024
@BigBlackWolf BigBlackWolf dismissed muncus’s stale review June 30, 2024 08:57

Fixed comments in separate commit

@BigBlackWolf BigBlackWolf merged commit 39ff0ec into main Jun 30, 2024
11 checks passed
@BigBlackWolf BigBlackWolf deleted the compute_images_create_from_image branch June 30, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants