Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed duplicated detect intent call if parameters are provided. #175

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Mrpatekful
Copy link
Collaborator

Based on our discussion @kmaphoenix my understanding is that the detect_intent call in the if parameters: ... block is not intended.

Moved the DetectIntentRequest setup code outside the if..else.. block and removed the unintended session_client.detect_intent call.

Patrik Purgai [email protected]

Copy link

google-cla bot commented Feb 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@kmaphoenix kmaphoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmaphoenix kmaphoenix merged commit 822dc97 into main Feb 27, 2024
5 checks passed
@kmaphoenix kmaphoenix deleted the bug/detect_intent_double_call branch February 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants