-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] update_webhook doesn't work properly when you pass a webhook_obj #111
Labels
bug
Something isn't working
Comments
Merged
Merged
@MRyderOC I just tested this on If I don't pass any kwargs to the method, nothing is updated. If I pass a kwarg to the method, it updates just fine. from google.protobuf import duration_pb2
all_webhooks = w.list_webhooks(pmarlow_demo)
duration = duration_pb2.Duration()
duration.seconds = 10
w.update_webhook(all_webhooks[0].name, all_webhooks[0], timeout=duration) Before proto
After proto
|
This specific bug will be addressed via another patch / branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Update the webhook in the target agent.
Current Behavior
Does not perform any action.
Possible Solution
based on https://github.com/googleapis/python-dialogflow-cx/blob/f2d12c53804dec7b236509aa29b200aebcc53c8a/google/cloud/dialogflowcx_v3beta1/types/webhook.py#L305-L308
we have to update the
mask
only if thekwargs
pass to the function and not when we pass thewebhook_obj
.Steps to Reproduce
list_webhooks
method indfcx_scrapi.core.webhoks.Webhooks
timeout
Possible Implementation
The text was updated successfully, but these errors were encountered: