Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to manifest version 3 #79

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Migrate to manifest version 3 #79

merged 2 commits into from
Sep 15, 2022

Conversation

beaufortfrancois
Copy link
Collaborator

This PR aims to migrate the chrome extension to manifest version 3:

This update should be transparent to users.

@nopeless
Copy link

Looks good. I should have split my PR into two

Copy link

@markafoltz markafoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good with a couple of minor comments

src/background.js Show resolved Hide resolved
src/manifest.json Outdated Show resolved Hide resolved
Copy link

@markafoltz markafoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants