Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: delete full config #9930

Merged
merged 2 commits into from
Nov 6, 2019
Merged

core: delete full config #9930

merged 2 commits into from
Nov 6, 2019

Conversation

patrickhulce
Copy link
Collaborator

Summary
per request in #9854 (comment) this deletes the full config now that js coverage is part of default. we haven't had anything else to add to the full config in its 2 year existence, so seems pretty safe to remove

@patrickhulce patrickhulce changed the base branch from enable_js_coverage to master November 6, 2019 17:24
@vercel vercel bot temporarily deployed to staging November 6, 2019 17:25 Inactive
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✂️✂️

lighthouse-core/test/config/config-test.js Show resolved Hide resolved
@brendankenny brendankenny merged commit c2a4696 into master Nov 6, 2019
@brendankenny brendankenny deleted the delete_full_config branch November 6, 2019 21:49
connorjclark added a commit that referenced this pull request Nov 7, 2019
Squashed commit of the following:

commit 1a053c4
Author: Connor Clark <[email protected]>
Date:   Wed Nov 6 17:31:14 2019 -0800

    bundling for devtools

commit 082715b
Author: Brendan Kenny <[email protected]>
Date:   Wed Nov 6 18:41:52 2019 -0500

    feedback

commit 948ee09
Author: Brendan Kenny <[email protected]>
Date:   Tue Nov 5 17:50:55 2019 -0500

    WIP: include plugin in dt build

commit c2a4696
Author: Patrick Hulce <[email protected]>
Date:   Wed Nov 6 15:49:28 2019 -0600

    core: delete full config (#9930)

commit d53284c
Author: Brendan Kenny <[email protected]>
Date:   Wed Nov 6 16:33:41 2019 -0500

    core: fix icu error thrown while throwing protocol error (#9935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants