Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add PageSpeed Green to to related projects #10018

Merged
merged 3 commits into from
Nov 25, 2019
Merged

docs(readme): add PageSpeed Green to to related projects #10018

merged 3 commits into from
Nov 25, 2019

Conversation

olex-green
Copy link
Contributor

Summary
Add PageSpeed Green to Lighthouse Integrations section.
Related Issues/PRs
There are no related issues/PRs

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat stuff @alexgreencode! would love to see some screenshots of the product on the homepage too :D

just to clarify, this is actually running on your own infrastructure using lighthouse and puppeteer, not just monetizing the PageSpeed Insights API right? :)

readme.md Outdated
@@ -293,6 +293,8 @@ This section details services that have integrated Lighthouse data. If you're wo

* **[Lighthouse Keeper](https://lighthouse-keeper.com/)** - Lighthouse Keeper monitors your pages' Lighthouse scores and notifies you if they drop below your thresholds. Lighthouse Keeper is a free service that monitors up to 3 URLs once per day.

* **[PageSpeed Green](https://pagespeed.green/)** - New web performance monitoring service for web pages. For now, you can track PageSpeed performance indicators for unlimited domains and web pages. Coming, running in different regions and CD/CI integration. Powered By Google Lighthouse and Puppeteer. You can easily start using PageSpeed Green with 30-day trial.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **[PageSpeed Green](https://pagespeed.green/)** - New web performance monitoring service for web pages. For now, you can track PageSpeed performance indicators for unlimited domains and web pages. Coming, running in different regions and CD/CI integration. Powered By Google Lighthouse and Puppeteer. You can easily start using PageSpeed Green with 30-day trial.
* **[PageSpeed Green](https://pagespeed.green/)** - Web performance monitoring service that tracks Lighthouse performance indicators on unlimited domains and web pages. PageSpeed Green is a paid product with a 30-day trial.

maybe come back to add the next sentence about different regions and CI/CD once it's implemented :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickhulce Thanks for review! Yes, it my own infrastructure. Yes, good advise about screenshots. Ok, I'll remove info about future's features.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you dislike the other edits? the other paid products follow the model of X is a paid product with a Y-day trial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like to be similar :-) Ok, I changed to the existing approach

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@olex-green
Copy link
Contributor Author

@patrickhulce I removed future features - please review

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM!

@patrickhulce patrickhulce merged commit 9be09da into GoogleChrome:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants