Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 check if a mod is_loadable #215

Merged
merged 1 commit into from
Apr 16, 2023
Merged

fix: 🐛 check if a mod is_loadable #215

merged 1 commit into from
Apr 16, 2023

Conversation

KANAjetzt
Copy link
Member

Mods should not pass the dependency check if one of there dependencies are not loadable.

@KANAjetzt
fix: 🐛 check if a mod is_loadable
53a6cce 
Mods should not pass the dependency check if one of there dependencies are not loadable.
@KANAjetzt KANAjetzt added the bug Something isn't working label Apr 14, 2023
@KANAjetzt KANAjetzt added this to the v6.0.0 milestone Apr 14, 2023
@KANAjetzt KANAjetzt requested review from Qubus0, ithinkandicode and a team April 14, 2023 23:17
@KANAjetzt KANAjetzt self-assigned this Apr 14, 2023
Qubus0
Qubus0 approved these changes Apr 15, 2023
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@KANAjetzt KANAjetzt added this pull request to the merge queue Apr 16, 2023
Merged via the queue into GodotModding:development with commit 34bcb83 Apr 16, 2023
@KANAjetzt KANAjetzt deleted the fix_dependency_check branch April 16, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

@ithinkandicode ithinkandicode Awaiting requested review from ithinkandicode

Assignees

@KANAjetzt KANAjetzt

Labels
bug Something isn't working
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@KANAjetzt @Qubus0