support for openflow 1.3 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we were missing some tests
Fixing data types in xsd
adding prefix merge capability
| @@ -216,23 +243,21 @@ def changeSwitchForwardingState(self, dpid=None, header=None, actions=None, comm | |||
| obj['in_port'] = None | |||
|
|
|||
| if(header.has_key('nw_src')): | |||
| if header['nw_src'].version == 6: | |||
| obj['dl_type'] = 34525 | |||
There was a problem hiding this comment.
Seems like there needs to be an else here??? OF 1.0 can't include IPv6 maybe Ryu is doing something special for us? In any case I think it is safer to have an else so that we don't try and set the nw_src/dst for IPv6 in OF1.0
| if(prefix._version != 4): | ||
| header = {"dl_type": 34525} | ||
| header = {"dl_type": 34525, |
There was a problem hiding this comment.
can we remove this if? seems like this is taken care of based on the prefix type later on?
|
Fixed the above specified bugs/issues. |
|
Hey Nikhil, Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
OpenFlow 1.3and support for merging of prefixes