This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
Remove user_load call in og_get_user_roles #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents adding a partial user object to the entity cache because og_get_user_roles is called during user_save().
|
I forgot to mention: the effect of having a partial object in de user entity cache is that the realname will not be properly generated for email notifications. |
|
This makes sense to me. |
jacobembree
added a commit
to jacobembree/og
that referenced
this pull request
Jan 11, 2019
MPParsley
reviewed
Aug 9, 2020
|
Since https://www.drupal.org/project/og/issues/3467694 was merged into the Thank you for contributing to Organic groups module. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents adding a partial user object to the entity cache because og_get_user_roles is called during user_save().