Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] Add support for prefixed URIs on base path #726

Open
wants to merge 2 commits into
base: 11.15
Choose a base branch
from

Conversation

abelharisov
Copy link

@abelharisov abelharisov commented Oct 17, 2022

Support custom gitlab installations with url like host/some/path/to/gitlab

@stale
Copy link

stale bot commented Feb 18, 2023

This issue has been automatically marked as stale because there has been no recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 18, 2023
@GrahamCampbell
Copy link
Member

Thanks for the PR. I feel that this is a breaking change, so I think we need to delay this until a v12.0.0 release.

@GrahamCampbell GrahamCampbell changed the title Support custom gitlab installations with url like host/some/path/to/gitlab [12.0] Add support for prefixed URIs on base path Mar 6, 2023
@GrahamCampbell GrahamCampbell changed the base branch from 11.8 to 11.10 March 6, 2023 22:58
src/Api/Projects.php Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jul 26, 2023

This issue has been automatically marked as stale because there has been no recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 26, 2023
@GrahamCampbell
Copy link
Member

not stale

@stale stale bot removed the stale label Jul 26, 2023
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because there has been no recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 15, 2023
@GrahamCampbell
Copy link
Member

Not stale

@stale stale bot removed the stale label Dec 15, 2023
@GrahamCampbell GrahamCampbell changed the base branch from 11.10 to 11.15 March 17, 2024 21:39
@GrahamCampbell
Copy link
Member

This PR is still in consideration for the next major version.

@datawench
Copy link

Any thoughts on when this might become current? I happen to have a project that has a nonstandard self-hosted path (it's like gitlab.myproject.com/gitlab), and it's taken me a while to track down that this is why the host attribute of the request's URI gets hosed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants