Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.3] Add support for a single inherited member #625

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

YKWeyer
Copy link
Contributor

@YKWeyer YKWeyer commented Mar 4, 2021

This adds support for reading the permissions of a specific member for a group/project including inherited permissions:
https://docs.gitlab.com/ee/api/members.html#get-a-member-of-a-group-or-project-including-inherited-members

I tried to respect the naming logic already used:

All members Single member
Without inheritance members member
With inheritance allMembers allMember

If you think this might be confusing, i could also name it inheritedMember (although this might not be perfect either, since both regular AND inherited members will be returned)

@GrahamCampbell
Copy link
Member

Thanks for this. Could you add some tests too?

@YKWeyer YKWeyer force-pushed the feature/add-inherited-member branch from 5d9cae6 to e2f8263 Compare March 5, 2021 09:59
@YKWeyer YKWeyer force-pushed the feature/add-inherited-member branch from e2f8263 to 59abb9c Compare March 5, 2021 10:08
@YKWeyer
Copy link
Contributor Author

YKWeyer commented Mar 5, 2021

👍 I just added tests for the two allMember methods.

This might be caused by my setup, but make install wouldn't succeed entirely ("Couldn't find any bin namespace."), and I had to
add "phpunit/phpunit": "^9.0", in the dev requirements of composer in order to run the tests.

@GrahamCampbell
Copy link
Member

Try running make clean && make install && make test. You may get some bin warnings, but they should be harmless.

@GrahamCampbell
Copy link
Member

If you have custom composer config in your home directory or globally installed packages, it's possible that could have messed things up.

@GrahamCampbell
Copy link
Member

Anyway, this looks good to me. Thanks. 🍻

@GrahamCampbell GrahamCampbell merged commit 16b4dea into GitLabPHP:11.3 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants