Pagination of Project Members

[tobiasetter]

GitLab API per default defines 20 items per_page for the returned result. Now if a project has more than 20 members we have an issue with increasing the number of items to max i.e. 100.

Therefore I complemented your code.

Many thanks!

[fbourigault]

Thank you for your contribution. Could you use the OptionsResolver like in https://github.com/m4tthumphrey/php-gitlab-api/blob/master/lib/Gitlab/Api/Projects.php#L35?

However, you have to do a little more work to not break BC. You will have to accept $username_query to be a string or an array and if it's a string, use it like the current code + trigger a deprecation notice. If it's an array or a null value, treat it as the argument you have to pass to OptionsResolver::resolve.

[tobiasetter]

I had to remove deprecated notice, because it was catched by build ci.

Maybe you know another way to implement this deprecation notice. Thanks

[fbourigault]

You have to write @trigger_error.

[tobiasetter]

@fbourigault thanks for your help.

@m4tthumphrey what do you think about a merge?

[m1guelpf]

@fbourigault This is a breaking change. Maybe find a way to make it backwards-compatible?

[tobiasetter]

@fbourigault What are the next steps? Do you want to merge or do we have to find a way to make it backwards-compatible as @m1guelpf suggested?

[tobiasetter]

@m1guelpf It already is backwards compatible. There is only a notice triggered that the string parameter is being deprecated.

[tobiasetter]

now it would also close issue #259

pull requests #310 and #286 both are resolved by this pull request

[tobiasetter]

@20uf I would be very happy if you could approve my new changes

[m1guelpf]

@tobiasetter Can you fix the tests?

[tobiasetter]

@m1guelpf what do you mean? all tests were successful

[m1guelpf]

@tobiasetter Sorry, I meant merge conflicts

[tobiasetter]

@m1guelpf Sure, no problem =)

[m1guelpf]

@tobiasetter Thank you for your contribution!

[tobiasetter]

@m1guelpf how about creating a new release?