Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace $() bashism with backticks #7

Closed
wants to merge 2 commits into from
Closed

Conversation

phdru
Copy link
Contributor

@phdru phdru commented Jun 25, 2016

No description provided.

The alias needs a shell but not necessary bash.
@joelparkerhenderson
Copy link
Member

Thanks for the idea. This project aims to use the git coding guidelines.

https://github.com/git/git/blob/6f92e5ff3cdc813de8ef5327fd4bad492fb7d6c9/Documentation/CodingGuidelines#L72-L74

"We prefer $( ... ) for command substitution; unlike ``, it properly nests. It should have been the way Bourne spelled it from day one, but unfortunately isn't."

Here's a link that helps show the $(...) on more shells than just bash, and also in the POSIX shell.

http:https://stackoverflow.com/questions/4708549/whats-the-difference-between-command-and-command-in-shell-programming

I'll have this pull request open for a week or so if people want to comment on it.

@phdru phdru deleted the bashisms branch July 3, 2016 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants