Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes and simplification for existing aliases #54

Merged
merged 3 commits into from
Sep 4, 2019

Conversation

romain-dartigues
Copy link
Contributor

I fixed a few aliases which did not behave at they should (at least under git 2.23.0), proposed a few simplifications and added a VIm modeline and emacs mode to enable syntax highlighting.

Any feedback appreciated.

* "$@" was ignored
* avoid `| grep` when awk can do the job as well
* use the simpler natural sort over the more complex --general-numeric-sort
* commit-parents: "$1" was unavailable
* commit-is-merge: the object was hard-coded
* avoid a `| grep` when sed can do the job
Copy link
Contributor

@phdru phdru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at 1st glance. I didn't test the code.

@joelparkerhenderson
Copy link
Member

Thank you! Your improvements are great. Very much appreciated.

@joelparkerhenderson joelparkerhenderson merged commit 9354877 into GitAlias:master Sep 4, 2019
@romain-dartigues
Copy link
Contributor Author

Wow! fast, where is the one-week delay before merging ;^) thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants