Modify topic-base-branch-name #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default branch according to HEAD position.
phdru
reviewed
Nov 6, 2018
| @@ -860,7 +860,9 @@ | |||
| ## | |||
|
|
|||
| topic-base-branch-name = "!f(){ \ | |||
| printf \"master\n\"; \ | |||
| head_path=$(git symbolic-ref refs/remotes/origin/HEAD); \ | |||
There was a problem hiding this comment.
$ git remotes
gh [email protected]:phdru/ppu.git (fetch)
gh [email protected]:phdru/ppu.git (push)
origin /home/phd/prog/Python/ppu (fetch)
origin /home/phd/prog/Python/ppu (push)
$ git symbolic-ref refs/remotes/origin/HEAD
fatal: ref refs/remotes/origin/HEAD is not a symbolic refOuch! Are you sure refs/remotes/origin/HEAD always exists?
|
Thanks for the suggestion. Can you help me understand how your code ensures that it finds the right branch name that a user wants to use for creating a new topic branch? The existing code always returns "master", which surely isn't right for everyone. For example, some teams use a branch named "develop", some teams use a branch named "trunk", etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default branch according to HEAD position.