put alias error

[berkin]

the push command also run with the parameter and it gives error.

git put test 
[master b9f5249] test
 1 file changed, 1 insertion(+), 1 deletion(-)
fatal: 'test' does not appear to be a git repository
fatal: Could not read from remote repository.

[phdru]

There is a big difference between git commit --all and git add -A && git commit. Is the change intentional?

[joelparkerhenderson]

Excellent point, thank you.

[phdru]

Also can I ask to fix minor style problem: two spaces before }?

[berkin]

thanks, i fixed.

[joelparkerhenderson]

Good discovery. Thank you. Definitely a bug.

The intent of get and put is primarily "Do the typical thing for the typical case".

What are opinions on whether adding the "git add -A" is the typical thing for the typical case?

If so, this would alter the alias, beyond just fixing the bug.

Just doing a bug fix could be more akin to this:

git commit --all --message="$1"; shift; git push \"$@\"

[erikmd]

What are opinions on whether adding the "git add -A" is the typical thing for the typical case?

I think git add -A && git commit -m ... && git push is probably too rude, because it will silently add everything that is not tracked, then commit and push it... so I'd vote for keeping this PR as a bugfix and just run

git commit --all --message="$1"; shift; git push \"$@\"

[erikmd]

Another solution for accepting multiple arguments would be to turn them into several -m flags, i.e.:

git commit -m "Title" -m "First paragraph..." -m "Second paragraph..."

[berkin]

What are opinions on whether adding the "git add -A" is the typical thing for the typical case?

The comment above the aliases says it will synchronise all changes so adding untracked files makes sense to me. Maybe it is better to change it with git add ., it will commit changes under that folder only.

[phdru]

I'm -0 about git add -A and +1 on the style change.

[joelparkerhenderson]

Thanks all for comments!

Here's feedback I received from a peer about principles:

• Fix each bug in its own commit.
• Do the fix with similar syntax if possible to make it easier for readers to understand.
• Do any implementation change (e.g. change to f()) in its own commit as a "Refactor ..."
• Do any feature change (e.g. change to add --all) in its own commit as an "Add ..."

Here's the fix code that seems to work for me, that's the closest to the syntax:

 put = !git commit --all --message=\"$1\" && shift && git push

@berkin Do you want credit for this fix? If you do, can you adjust the PR to be just the fix? If you don't care, then let me know and I can do it. If you would like, you can do a subsequent PR to do the refactor of get and put to use functions.

Thanks!