Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShellCheck and fix many warnings #106

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Conversation

lorenzleutgeb
Copy link
Member

@lorenzleutgeb lorenzleutgeb commented Oct 20, 2023

Closes #105

  1. I decided to ignore three errors for now:
    • SC2094 only occurs once. I do indeed think it is a problem that git ignore will read and write to .gitignore in one chain of pipes. However, I do think that the alias should be rewritten (use git status -u).
    • SC2119 and SC2120 go together, and they complain about the !f() { ... }; f gadget that many aliases use.
  2. Created a workflow for GitHub Actions. Not sure whether shellcheck.sh really belongs into /, but I couldn't think of a better place. Happy to move it elsewhere.
  3. Also moved CODEOWNERS since there's now .github.

@joelparkerhenderson joelparkerhenderson merged commit 12c40fc into main Oct 22, 2023
2 checks passed
@joelparkerhenderson joelparkerhenderson deleted the shellcheck branch October 22, 2023 21:20
@joelparkerhenderson
Copy link
Member

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shellcheck
3 participants