GSK-146: update demo projects with new giskard client #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreybavt
requested changes
Jun 20, 2022
| @@ -20,6 +20,9 @@ scikit-learn = ">=1.0.2" | |||
| shap = ">=0.40.0" | |||
| zstandard = "^0.15.2" | |||
| numpy = "^1.21.6" | |||
| #torch = ">=1.10.0" | |||
There was a problem hiding this comment.
is there a reason to have them commented?
| try { | ||
| saveProject(key, config.creator); | ||
| } catch (IOException e) { | ||
| logger.error(e.getMessage()); |
There was a problem hiding this comment.
two logging calls looks redundant, the second one will include e.getMessage() too
giskard-server/src/main/java/ai/giskard/service/InitService.java
Outdated
Show resolved
Hide resolved
andreybavt
requested changes
Jun 21, 2022
There was a problem hiding this comment.
Overall the PR looks good to me now. I tested the demo models and datasets, it works fine.
My two last comments are:
- model names (see
uploadModel) - German_credit_scoring_giskard.ipynb is still using ModelInspector, can you adapt it to the new API? It's the notebook that we ship with our demo
jupytercontainer.
| Resource modelResource = resourceLoader.getResource(pathToModel); | ||
| Resource requirementsResource = resourceLoader.getResource(pathToRequirements); | ||
| ModelUploadParamsDTO modelDTO = projects.get(projectKey).modelParams; | ||
| modelDTO.setName(modelDTO.getName() + " " + filename); |
There was a problem hiding this comment.
you're modifying the shared ModelUploadParamsDTO. This results in model names like "German credit score 0 1" because on the first iteration "0" was already appended to the name. We should create a copy of projects.get(projectKey).modelParams here before modifying it.
|
Kudos, SonarCloud Quality Gate passed! |
andreybavt
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.