GSK-58 Project Migration #35

qgk75 · 2022-04-13T13:43:06Z

setting routes for project api (no permissions)
deleting controllers for project for the moment
updating schema in project

- setting routes for project api (no permissions)

webappio · 2022-04-13T13:43:10Z

⬇️ Preview environment ⬇️

# Conflicts: # giskard-server/src/main/java/ai/giskard/web/rest/project/DatasetsController.java # giskard-server/src/main/java/ai/giskard/web/rest/project/ModelsController.java

gitguardian · 2022-04-14T08:24:35Z

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
3028168	Generic High Entropy Secret	`a6a7631`	.env	View secret
3028169	Generic High Entropy Secret	`a6a7631`	.env	View secret
3028169	Generic High Entropy Secret	`a6a7631`	backend/java-app/.yo-rc.json	View secret
3028169	Generic High Entropy Secret	`a6a7631`	backend/java-app/src/main/docker/jhipster-control-center.yml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

# Conflicts: # giskard-server/src/main/java/ai/giskard/domain/User.java

…guestlist

… authorities

andreybavt

Some extra changes to be made, but generally speaking it looks good!

.github/workflows/build.yml

giskard-server/src/main/java/ai/giskard/domain/Project.java

giskard-server/src/main/java/ai/giskard/domain/User.java

giskard-server/src/main/java/ai/giskard/repository/ProjectRepository.java

giskard-server/src/main/java/ai/giskard/service/mapper/GiskardMapper.java

giskard-server/src/main/java/ai/giskard/web/rest/controllers/ModelsController.java

giskard-server/src/main/java/ai/giskard/web/rest/controllers/ProjectController.java

giskard-server/src/main/java/ai/giskard/web/rest/errors/EntityAccessControlException.java

giskard-server/src/test/java/ai/giskard/service/InitService.java

andreybavt · 2022-04-26T09:45:23Z

also as part of this PR we should get rid of giskard-legacy-server/app/api/api_v1/endpoints/projects.py and migrate the UI to use v2 endpoints

giskard-server/src/main/java/ai/giskard/service/dto/ml/DatasetDTO.java

giskard-server/src/main/java/ai/giskard/service/dto/ml/ModelDTO.java

andreybavt · 2022-04-28T22:02:51Z

giskard-server/src/main/java/ai/giskard/service/dto/ml/ProjectPostDTO.java

+@Getter
+@Setter
+@NoArgsConstructor
+public class ProjectPostDTO {


description property is missing, it's used here for example: ProjectsHome.submitNewProject

andreybavt · 2022-04-29T14:24:53Z

giskard-server/src/main/java/ai/giskard/domain/Role.java

 private int id;

 @lombok.Setter
 @lombok.Getter
 @NotNull
+ @Unique
 @Size(max = 50)
 @Column(length = 50)


Are you sure you wanted a @unique annotation from checkerframework and not just @column(length = 50, unique=true)?

yes changing this

… java-api

…dencies

…ject migration

…oject migration

GSK-4 Java migration

afd0cc1

- setting routes for project api (no permissions)

andreybavt self-requested a review April 14, 2022 08:18

Merge branch 'feature/ai-test' into java-api

a6a7631

# Conflicts: # giskard-server/src/main/java/ai/giskard/web/rest/project/DatasetsController.java # giskard-server/src/main/java/ai/giskard/web/rest/project/ModelsController.java

qgk75 added 18 commits April 14, 2022 17:40

Merge remote-tracking branch 'origin/feature/ai-test' into java-api

241ecf5

Merge branch 'feature/ai-test' into java-api

adb73c3

Merge branch 'feature/ai-test' into java-api

7c3dfdc

adding projects get methods

4b9c52c

add invite uninvite methods to project's controller

d62eeb7

Merge branch 'feature/ai-test' into java-api

e0c4a3f

access control admin or owner

f12af37

add mapper between dto and entities

a6ab070

refactoring test conditions in project access control

fe72f86

Merge branch 'feature/ai-test' into java-api

ed79403

# Conflicts: # giskard-server/src/main/java/ai/giskard/domain/User.java

replacing user query by project query to get projects by owner or in …

fd49f8a

…guestlist

testing methods with admin authorities

f8dac02

GSK-58 Project Migration: moving tests to rest controllers package

d4f089a

GSK-58 Project Migration: adding test for project with admin authorities

9d7d140

GSK-58 Project Migration: finalizing tests for project with different…

72cd21d

… authorities

GSK-58 Project Migration: refactoring tests

824f19b

GSK-58 Project Migration: prefer annotation for access control

94d5798

Merge branch 'feature/ai-test' into java-api

521dd90

qgk75 marked this pull request as ready for review April 25, 2022 13:54

qgk75 added 2 commits April 25, 2022 15:17

attempt to solve python build error on github actions

a5c6f91

solve build error commenting sonarqube

5312c2c

andreybavt suggested changes Apr 26, 2022

View reviewed changes

qgk75 added 2 commits April 26, 2022 12:43

GSK-4 Java migration: fixing javadoc on main

3386b39

GSK-4 Java migration: linking sonarqube todo to task

5e5940e

qgk75 and others added 4 commits April 27, 2022 13:10

Merge remote-tracking branch 'origin/java-api' into java-api

e70a322

GSK-58 Project Migration: remove boiler plate with lombok annotation

8fefbf5

GSK-58 Project Migration: add unit tests for the permission evaluator

5019769

Merge branch 'feature/ai-test' into java-api

8ca721d

andreybavt self-requested a review April 28, 2022 13:08

andreybavt reviewed Apr 28, 2022

View reviewed changes

giskard-server/src/main/java/ai/giskard/service/dto/ml/DatasetDTO.java Show resolved Hide resolved

andreybavt reviewed Apr 28, 2022

View reviewed changes

giskard-server/src/main/java/ai/giskard/service/dto/ml/ModelDTO.java Outdated Show resolved Hide resolved

andreybavt reviewed Apr 28, 2022

View reviewed changes

GSK-58 Project Migration: correct dtos model

d154041

andreybavt changed the title ~~GSK-4 Java migration~~ GSK-58 Project Migration Apr 29, 2022

qgk75 and others added 2 commits April 29, 2022 14:25

GSK-58 Project Migration: sending msg on delete function

c37ddbb

cleanup

785a907

andreybavt reviewed Apr 29, 2022

View reviewed changes

qgk75 and others added 14 commits April 29, 2022 15:30

GSK-58 Project Migration: incorrect annotation on role for unique name

773e8c8

cleanup + SecurityUtils.getCurrentAuthenticatedUserLogin()

f5f32e7

cleanup

c7a520e

cleanup and temporarly merge name and filename when sending it to the UI

c4d0bdd

Merge branch 'java-api' of https://github.com/Giskard-AI/giskard into…

a93b6d6

… java-api

GSK-58 Project Migration: add cascade for deleting project with depen…

092fc02

…dencies

GSK-58 Project Migration: return no response for deleting project

bbd279c

GSK-58 Project Migration: restoring mapping only on controller

1ffa905

GSK-58 Project Migration: back: Solving test suites problems with pro…

f781cb1

…ject migration

GSK-58 Project Migration: back: Solving test suites problems with pro…

0cc1ac4

…ject migration

GSK-58 Project Migration: front: Solving test suites problems with pr…

ee67e44

…oject migration

fixing typescript error

0f1fa9e

GSK-58 Project Migration: Solve lazyloading exception on controller

357c394

moved InitService to tests

59b84f3

andreybavt self-requested a review May 4, 2022 12:31

andreybavt approved these changes May 4, 2022

View reviewed changes

andreybavt merged commit 99dcc35 into feature/ai-test May 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GSK-58 Project Migration #35

GSK-58 Project Migration #35

qgk75 commented Apr 13, 2022

webappio bot commented Apr 13, 2022 •

edited

Loading

gitguardian bot commented Apr 14, 2022 •

edited

Loading

andreybavt left a comment

andreybavt commented Apr 26, 2022

andreybavt Apr 28, 2022

andreybavt Apr 29, 2022

qgk75 Apr 29, 2022

GSK-58 Project Migration #35

GSK-58 Project Migration #35

Conversation

qgk75 commented Apr 13, 2022

webappio bot commented Apr 13, 2022 • edited Loading

⬇️ Preview environment ⬇️

gitguardian bot commented Apr 14, 2022 • edited Loading

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

andreybavt left a comment

Choose a reason for hiding this comment

andreybavt commented Apr 26, 2022

andreybavt Apr 28, 2022

Choose a reason for hiding this comment

andreybavt Apr 29, 2022

Choose a reason for hiding this comment

qgk75 Apr 29, 2022

Choose a reason for hiding this comment

webappio bot commented Apr 13, 2022 •

edited

Loading

gitguardian bot commented Apr 14, 2022 •

edited

Loading