Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversation correctness evaluation #1946

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add conversation correctness evaluation #1946

wants to merge 5 commits into from
+46 −33

Conversation

pierlj
Copy link
Contributor

@pierlj pierlj commented May 30, 2024

No description provided.

@linear Linear
Copy link

linear bot commented May 30, 2024

GSK-3579 Correctness evaluator does not take into account full conversation

@pierlj pierlj requested a review from mattbit May 30, 2024 15:17
@sentry-io Sentry.io
Copy link

sentry-io bot commented May 30, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: giskard/rag/metrics/correctness.py

Function Unhandled Issue
__call__ LLMGenerationError: Error while evaluating the agent main in <mod...
Event Count: 6

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbit mattbit Awaiting requested review from mattbit

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pierlj @kevinmessiaen