Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS AMI creation #161

Merged
merged 3 commits into from
Jul 26, 2022
Merged

AWS AMI creation #161

merged 3 commits into from
Jul 26, 2022

Conversation

reneab
Copy link
Contributor

@reneab reneab commented Jul 16, 2022

Description

Infrastructure changes to create AMIs on AWS and ideally automate their creation based on release tags

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@reneab reneab changed the title have a docker-compose to open port 80 in AWS AMI AWS AMI creation Jul 16, 2022
@reneab reneab marked this pull request as draft July 16, 2022 11:26
@andreybavt
Copy link
Contributor

@reneab could you please also add systemd config file to git so that we keep track of it too?

@andreybavt andreybavt self-requested a review July 18, 2022 15:27
@reneab
Copy link
Contributor Author

reneab commented Jul 19, 2022

@reneab could you please also add systemd config file to git so that we keep track of it too?

You're right, it's done.
I also added a command there to prune images after push and up, it's better this way

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andreybavt andreybavt marked this pull request as ready for review July 26, 2022 11:14
@andreybavt andreybavt merged commit 912e663 into main Jul 26, 2022
reneab
reneab commented Jul 29, 2022
View reviewed changes
scripts/infrastructure/giskard-docker-start.service
ExecStartPre=-/bin/bash -c "/bin/curl -f 'https://raw.githubusercontent.com/Giskard-AI/giskard/main/docker-compose.yml' -o docker-compose.yml"
ExecStartPre=-/usr/local/bin/docker-compose pull --quiet
ExecStart=/usr/local/bin/docker-compose -f docker-compose.yml -f docker-compose.ami.yml up -d

ExecStartPost=/bin/bash -c "echo 'Pruning docker images...'"
ExecStartPost=-docker image prune -f
ExecStartPost=-/usr/local/bin/docker image prune -f
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @andreybavt je viens de checker et c'est pas correct, le path to docker c'est /usr/bin par default (et le path to docker-compose est different car il est installe differement, pas par yum)
Si tu es ok je vais pusher ca directement sur main?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @reneab , oui, push le directement, merci!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok et je rajoute un petit script aussi d'installation de docker et docker-compose sur AWS Linux, ca manquait, sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bon en fait j'ai cree une petit pull request c'est mieux
#184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreybavt andreybavt andreybavt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reneab @andreybavt