Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Little improvements #1479

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Little improvements #1479

merged 7 commits into from
Oct 16, 2023

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 13, 2023

Description

Some several small fixes, on logs, sonar issues and so on

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn self-assigned this Oct 13, 2023
@Hartorn Hartorn force-pushed the little-improvements branch 2 times, most recently from 42e4f95 to e46ffd5 Compare October 13, 2023 14:06
@mattbit mattbit self-requested a review October 13, 2023 14:50
@mattbit
Copy link
Member

mattbit commented Oct 13, 2023

sorry, just realized that this was still a draft

@Hartorn Hartorn marked this pull request as ready for review October 16, 2023 11:53
@Hartorn
Copy link
Member Author

Hartorn commented Oct 16, 2023

sorry, just realized that this was still a draft

No worries. Do you want to re-check or can I merge ?

mattbit
mattbit approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@mattbit mattbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, just a commend about the deep copy of df but not blocking.

giskard/models/model_explanation.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Hartorn Hartorn merged commit 4a1e2da into main Oct 16, 2023
13 checks passed
@Hartorn Hartorn deleted the little-improvements branch October 16, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbit mattbit mattbit approved these changes

@andreybavt andreybavt Awaiting requested review from andreybavt

@rabah-khalek rabah-khalek Awaiting requested review from rabah-khalek

Assignees

@Hartorn Hartorn

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hartorn @mattbit