Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate again Sonar on the python code #1473

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Activate again Sonar on the python code #1473

merged 1 commit into from
Oct 11, 2023

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 10, 2023

Closes #GSK-1782

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn self-assigned this Oct 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hartorn Hartorn marked this pull request as ready for review October 10, 2023 20:13
@Hartorn Hartorn requested a review from a team as a code owner October 10, 2023 20:13
Inokinoki
Inokinoki approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hartorn Hartorn merged commit d9c13f3 into main Oct 11, 2023
13 checks passed
@Hartorn Hartorn deleted the activate-sonar branch October 11, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inokinoki Inokinoki Inokinoki approved these changes

@andreybavt andreybavt Awaiting requested review from andreybavt

Assignees

@Hartorn Hartorn

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hartorn @Inokinoki