Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gsk 1814 add a message error when the server is started with version #1445

Conversation

kevinmessiaen
Copy link
Member

Description

Added an error message when trying to start the server with a different version of the python library

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Oct 2, 2023

GSK-1814 Add a message error when the server is started with version mismatch with the library

we should have an error message when we start the server from cli if the version mismatch. And an option to ignore the issue like “giskard server start —skip-version-check”

@Hartorn Hartorn force-pushed the feature/gsk-1814-add-a-message-error-when-the-server-is-started-with-version branch from e8a8102 to 855fda3 Compare October 11, 2023 08:03
@kevinmessiaen kevinmessiaen merged commit 40c9cb6 into main Oct 11, 2023
11 checks passed
@kevinmessiaen kevinmessiaen deleted the feature/gsk-1814-add-a-message-error-when-the-server-is-started-with-version branch October 11, 2023 09:34
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants