Sort SHAP explanation charts #144

alexcombessie · 2022-07-08T21:24:19Z

https://giskard.youtrack.cloud/issue/GSK-158

alexcombessie · 2022-07-13T18:20:27Z

@andreybavt To check what it's doing, you can check the demo projects:

1. Zillow price prediction - regression

BEFORE

AFTER

2. German credit scoring - binary classification

BEFORE

AFTER

5. ENRON - multi classification

BEFORE

AFTER

andreybavt

I left some minor comments, plus there are a few "Code smells" from Sonar. Let me know if you have time to finish this PR, otherwise, I can do it myself @alexcombessie

docker-compose.yml

andreybavt · 2022-07-15T09:59:51Z

giskard-frontend/src/views/main/project/PredictionExplanations.vue

+ const explanationSumByFeature: object = {};
+ topFeatures.forEach((element, index) => {
+ explanationSumByFeature[element] = explanationSum[index];
+ });


simplification nitpick: explanationSum auxiliary array (and some other aux variables) creation can be avoided if you replace lines 158-170 with something like this:

// Compute the sum of SHAP explanations by feature const explanationSumByFeature: { [name: string]: number } = _.reduce( _.values(this.fullExplanations), (acc, labelExplanations) => { _.forOwn(labelExplanations, (featureName, explainValue) => { acc[explainValue] = (acc[explainValue] || 0) + featureName; }); return acc; }, {} )

here I'm using lodash that you can import with import _ from "lodash";

Sure, but I wonder if this version is not less readable? Also, are you 100% sure this is the same formula as the code I wrote? Just asking, since I spent over 3 hours to craft the formula and make sure it was correct.

If I'm not missing anything, your transforming Category->feature->explanation nested dictionary into feature->explanation dictionary by summing up explanations by feature across categories

yep exactly, with sorting

alexcombessie · 2022-07-15T10:43:59Z

I left some minor comments, plus there are a few "Code smells" from Sonar. Let me know if you have time to finish this PR, otherwise, I can do it myself @alexcombessie

Thanks! I took care of the code smells directly in 483a246

For the rest, I won't have time before next week. This afternoon I need to work on the EIC proposal, on which I am already quite late. So yeah if you can finish it, that would be fantastic, thanks!