Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_diff* tests fail with zero division if there are no correct predictions for the dataset #393

Closed
andreybavt opened this issue Dec 5, 2022 · 0 comments · Fixed by #594
Closed

test_diff* tests fail with zero division if there are no correct predictions for the dataset #393

andreybavt opened this issue Dec 5, 2022 · 0 comments · Fixed by #594
Assignees
@andreybavt
Labels
p:normal Normal priority yt Issues migrated from YouTrack

Comments

@andreybavt
Copy link
Contributor

GSK-391

instead of throwing an exception a test should fail with a human-readable message

Project: Giskard
Reporter: aavtomonov
Created: 2022-11-29
@andreybavt andreybavt added yt Issues migrated from YouTrack p:normal Normal priority yt_project:giskard labels Dec 5, 2022
@andreybavt andreybavt self-assigned this Dec 5, 2022
@Googleton Googleton linked a pull request Dec 9, 2022 that will close this issue
#393 Add always wrong model & data, make test fail if metric is invalid #594
Merged
2 tasks
andreybavt added a commit that referenced this issue Dec 9, 2022
@andreybavt
Merge pull request #594 from Giskard-AI/393-test_diff-tests-fail-with…
8b24a22 
…-zero-division-if-there-are-no-correct-predictions-for-the-dataset

#393 Add always wrong model & data, make test fail if metric is invalid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreybavt andreybavt

Labels
p:normal Normal priority yt Issues migrated from YouTrack
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#393 Add always wrong model & data, make test fail if metric is invalid Giskard-AI/giskard
1 participant
@andreybavt