Fix issues with parsing of Service binary paths

[OJ]

Seatbelt parses and enumerates services via WMI, and attempts to pull information out of the binaries that the service points to. There were a few issues with the approach that was taken:

• It didn't cover cases where service paths were quoted or had spaces (such as Motorola's Bluetooh OBEX Service).
• It didn't handle cases where service binaries didn't have an extension (such as Carbon Black's Sensor agent).
• It didn't seem to correctly handle arguments passed to the service.
• When errors were encountered while parsing the file information, there was no try/catch around a single case, and hence the entire service parsing loop was exited (resulting in the rest of the services not being enumerated).

This PR attempts to fix this problem. It should handle quoted service paths, files without extensions, and cases where arguments are passed to the service exe.

There are some thorough comments on the approach in the code, but basically it does the following:

1. Assumes that if a quote exists it's in the binary path, and makes use of that assumption, by taking what's after the first quote (based on a simple split). This might fail if the service binary isn't quoted, but an argument is quoted.
2. Assumes from there that anything before the first space is the target binary.
3. Catches the exception in the file version info call so that we don't bail on the whole loop.

This approach makes it work in the cases I saw breakages on a recent machine I ran it on.

Thoughts and feedback welcome. Thanks!

[OJ]

BUMP!

[leechristensen]

Tracking and has been added into the rearchitected version. Should have the new release out within a week :)

[OJ]

Rearchitected version?