Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Selection Dropdown UX Enhancements #1 #53

Open
anjj123 opened this issue May 6, 2019 · 7 comments
Open

Account Selection Dropdown UX Enhancements #1 #53

anjj123 opened this issue May 6, 2019 · 7 comments

Comments

@anjj123
Copy link
Contributor

anjj123 commented May 6, 2019

List of Account Selection Dropdown UX Enhancements:

1. Line separating accounts, and creation + import should not be selectable;

  1. The highlighting effect when cursor moves over options isn't noticeable enough; It just needs to be added for create/import

3. Dropdown highlight selection always defaults to the first account in the list, even if another account is selected; This was removed altogether.

4. The highlighted box doesn't cover the whole field (wallet name and public address - maybe move these closer or make the box larger)

  1. Dropdown box should be bigger, centered and closer to designs + text should also be a bit bigger (hard to read);

6. Selected account should be highlighted in the dropdown or go to the top of the list, and not always highlight the first account - also, the highlight isnt that noticeable; Removed

  1. Sometimes clicking to change accounts doesnt work - extension wont respond and requires a few clicks (firefox and chrome);

  2. Ability to move and reorganise accounts in the list; and

9. Grey box on account name when clicking dropdown

@mytechtip
Copy link
Contributor

Hi @anjj123 , except no.8, the rest of the items have been improved or fixed. Please verify. Thanks.

@anjj123
Copy link
Contributor Author

anjj123 commented May 13, 2019

Most of these are completed. There are still some issues:

  1. Highlighting effect doesn't apply to create/import account options;
  2. Text for account names is too small and hard to read;
  3. There is a performance issue where once you add an account with a balance, it sometimes doesnt register clicks when switching between accounts and may require double or triple clicks; and
  4. (As you said) ability to reorganise accounts in the list

OP has been edited to reflect these issues

@mytechtip
Copy link
Contributor

  1. the hover over effect on create/import account buttons causes the weird white screen issues on firefox. I would leave this as low priority.

  2. Adjusted the font size of account names in Firefox: UI Bug List #68

3 does it happens when adding/importing an account or when switching between accounts?

4 this could be a future enhancement

@anjj123
Copy link
Contributor Author

anjj123 commented May 14, 2019

  1. Understood and agreed.

  2. Perfect.

  3. Switching between accounts.

  4. Understood and agreed.

New issue:

  1. If Account name is too long, it causes bugs in the dropdown (such as scrollbar disappearing). Solved by enforcing Account Name character limits.

Screen Shot 2019-05-14 at 5 33 05 pm

  1. Grey bar on account name when clicking for dropdown.

Updating OP to reflect these issues.

For now, if we can solve the UX issue of switching between accounts sometimes requiring multiple clicks, the rest can be dropped to low priority.

@fyang1024
Copy link
Contributor

I cannot seem to reproduce the issue that switching accounts requires multiple clicks. @anjj123 please try to reproduce it and see if there is any pattern so that we can reproduce it and debug. Other than that, everything should be fixed now.

@anjj123
Copy link
Contributor Author

anjj123 commented May 14, 2019

You can see it on the gif i provided in the balance bug that we recently completed. The pattern seems to be that once I import an account with a balance, there is a performance issue with switching accounts

@anjj123
Copy link
Contributor Author

anjj123 commented May 14, 2019

@fyang1024 I have reproduced the issue again here
ezgif com-video-to-gif (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants