Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for '/announce.php' #27

Closed
drewbitt opened this issue May 9, 2018 · 4 comments
Closed

add support for '/announce.php' #27

drewbitt opened this issue May 9, 2018 · 4 comments

Comments

@drewbitt
Copy link

drewbitt commented May 9, 2018

You cannot add a tracker without the tracker url ending in /announce currently. However, a few (private) sites use site.com/announce.php announces. Once uploaded you get your unique announce url, but until then they require the announce me site.com/announce.php.

Allow the user to enter a tracker not ending in /announce

@GerryFerdinandus
Copy link
Owner

Thanks for reporting this issue.

To check for posible copy and paste error, the program look at the begin and the end of the URL line.
Must begin with https://, udp:https:// etc and end with /announce
If the line begin and end are correct then there should be no copy and paste error.


There are two posible solution:

  1. remove the check for /announce
  2. accept /announce and /announce.php

Solution 1.
Downside is the posible copy and paste error at the end of the line.
This will downgrade the robustness of the program.

Solution 2.
Add extra check in the program for /announce.php, maybe in the future there are more exception needed.

I will implement solution number 2: accept /announce and /announce.php


Some example list with /announce and /announce.php
https://github.com/ngosang/trackerslist/blob/master/trackers_all.txt
https://github.com/ngosang/trackerslist/blob/master/blacklist.txt

GerryFerdinandus added a commit that referenced this issue May 27, 2018
@GerryFerdinandus GerryFerdinandus changed the title Don't Force /announce add support for '/announce.php' May 27, 2018
@GerryFerdinandus
Copy link
Owner

A new 1.33.0.beta.5 version can be downloaded.

Please test/verify/report back.
So that this issue report can be closed.

@drewbitt
Copy link
Author

drewbitt commented Jun 1, 2018

Seems to work.

@ChaoticNeutralCzech
Copy link

Some trackers don't follow this, either. I will not say which tracker it is but the announce URL pattern is https://exampletracker.com/announce/deadbeefdeadbeefdeadbeefdeadbeef (may differ per user)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants