Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to Surface Area Duration NB #937

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Conversation

vnewey
Copy link
Collaborator

@vnewey vnewey commented Aug 5, 2022

Updated to Surface Area Duration NB to work with a newer version of pandas. + updated for DEA Waterbodies V2

Proposed changes

Updated to Surface Area Duration NB to work with a newer version of pandas. + updated for DEA Waterbodies V2

Checklist (replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • [x ] Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

Updated to Surface Area Duration NB to work with a newer version of pandas.
@vnewey vnewey requested a review from robbibt August 5, 2022 03:46
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vnewey, looks great! I pushed a tiny update to fix two missing images, and change a few CMI links that pointed to the old Waterbodies CMI link.

One more that's not necessary for now but would be work doing would be to update this notebook to use the get_waterbodies and get_timeseries funcs from dea_tools.waterbodies. I don't think they existed when this was first written, but they're a much easier method than accessing the CSVs directly. Maybe something to create an issue for?

@robbibt robbibt merged commit 6cddf52 into develop Aug 5, 2022
@robbibt robbibt deleted the SurfaceAreaDurationNBfix branch August 5, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants