Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update R^2 method in eval_metrics #1211

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Update R^2 method in eval_metrics #1211

merged 1 commit into from
Mar 19, 2024

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Mar 18, 2024 •
edited
Loading

Proposed changes

The current R^2 coefficient of determination method in eval_metrics produces confusing and unpredictable results. This PR simplifies this by simply squaring the linear regression correlation co-efficient, as recommended by the stats.linregress function:
https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.linregress.html
image

@robbibt robbibt marked this pull request as ready for review March 19, 2024 04:47
vnewey
vnewey approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@vnewey vnewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@vnewey vnewey merged commit 8f78d5d into develop Mar 19, 2024
1 check passed
@vnewey vnewey deleted the validation_update branch March 19, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnewey vnewey vnewey approved these changes

@BexDunn BexDunn Awaiting requested review from BexDunn BexDunn is a code owner

@erialC-P erialC-P Awaiting requested review from erialC-P erialC-P is a code owner

@uchchwhash uchchwhash Awaiting requested review from uchchwhash uchchwhash is a code owner

@Kooie-cate Kooie-cate Awaiting requested review from Kooie-cate Kooie-cate is a code owner

@geoscience-aman geoscience-aman Awaiting requested review from geoscience-aman geoscience-aman is a code owner

@JM-GA JM-GA Awaiting requested review from JM-GA JM-GA is a code owner

@margaretharrison margaretharrison Awaiting requested review from margaretharrison margaretharrison is a code owner

@Ariana-B Ariana-B Awaiting requested review from Ariana-B Ariana-B is a code owner

@amanda2099 amanda2099 Awaiting requested review from amanda2099 amanda2099 is a code owner

@supermarkion supermarkion Awaiting requested review from supermarkion supermarkion is a code owner

@erin-telfer erin-telfer Awaiting requested review from erin-telfer erin-telfer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbibt @vnewey