Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation step to integration tests Github Action #76

Merged
merged 115 commits into from
Feb 10, 2023

Conversation

robbibt
Copy link
Collaborator

@robbibt robbibt commented Feb 9, 2023

This PR adds a new validation test step to our integration tests so that each time the integration test is run, the Coastlines data produced is also used to run a small-scale validation of the results by comparing them to validation data from the Narrabeen-Collaroy Beach Survey Program. The ensures that the code both works, and generates sensible results.

The Github action does the following:

  1. Runs integation test that generates Coastlines data for Narrabeen Beach
  2. Validates the Coastlines data against validation data
  3. Exports a PNG image and a markdown file containings stats on the latest run
  4. Commits those files back into the repo so they're visible in the tests/README.md file

Some other small improvements include:

  • Moving all docker-compose test actions and file copying to a single shell script (docker/coastline/run_tests) for easier maintenance
  • Move some docker-compose files for updating the test database into the docker subfolder
  • Allow the buffer on the edge of scenes to be customised, so that the integration tests don't need to load more data than they need

@robbibt robbibt requested a review from vnewey February 9, 2023 23:28
@vnewey vnewey merged commit 6043a13 into develop Feb 10, 2023
@vnewey vnewey deleted the tests_validation branch February 10, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants