Skip to content

Commit

Permalink
Run one benchmark at a time (pulumi#1585)
Browse files Browse the repository at this point in the history
Before the change, benchmarks ran in parallel. We are observing very
high variance no the benchmarks, part of the problem could be resource
contention for network bandwidth across benchmarks. This change will
give the entire runner's worth of resources to each benchmark
individually, and hopefully reduce variance at the cost of using more CI
runner time. Will observe for 1 week and evaluate.
  • Loading branch information
t0yv0 committed Feb 12, 2024
1 parent e3cde53 commit 671a16f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/performance_metrics_cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
shell: bash
run: |
set -euo pipefail
cd misc/test && go test . --timeout 4h -count=1 -json -short -parallel 40 --tags=Performance 2>&1 | tee /tmp/gotest.log | gotestfmt
cd misc/test && go test . --timeout 4h -count=1 -json -short -parallel 1 --tags=Performance 2>&1 | tee /tmp/gotest.log | gotestfmt
- name: Upload traces GHA artifact
uses: actions/upload-artifact@v3
with:
Expand Down

0 comments on commit 671a16f

Please sign in to comment.