Skip to content

Commit

Permalink
Fixes to unblock cron tests (pulumi#1470)
Browse files Browse the repository at this point in the history
* Fix lint

* Use .net6

Many examples aren't currently working because they require .NET 6.

* Use Go 1.20 in GCP CloudFunctions
* Update all workflows to .NET 6
* Lint fix
* Set autoUpgrade on GKE cluster
Addresses:

```
    	* creating urn:pulumi:2685a705672d1eb7c15c51eab35db2fc1e8db553-1445::k8s-ci-cluster::gcp:container/nodePool:NodePool::primary-node-pool: 1 error occurred:
    	* error creating NodePool: googleapi: Error 400: Auto_upgrade must be true when release_channel STABLE is set.
```

* Use Node.js 20 in GCP CloudFunctions
* Fix S3 bucket examples
* Bump version of @pulumi/cloud
* Pin awscli version in FFMPEG Dockerfile
  • Loading branch information
lukehoban committed Jul 28, 2023
1 parent 446687f commit 5a48fdc
Show file tree
Hide file tree
Showing 87 changed files with 159 additions and 122 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
platform:
- ubuntu-latest
source-dir:
Expand Down Expand Up @@ -186,7 +186,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down Expand Up @@ -327,7 +327,7 @@ jobs:
- EquinixMetal
- Cloud
dotnetversion:
- 3.1.301
- 6.0.114
examples-test-matrix:
- default
goversion:
Expand Down Expand Up @@ -473,7 +473,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down Expand Up @@ -577,7 +577,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/performance_metrics_cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
fail-fast: false
matrix:
dotnet-version:
- 3.1.301
- 6.0.114
go-version:
- 1.19.x
node-version:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/run-tests-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
platform:
- ubuntu-latest
source-dir:
Expand Down Expand Up @@ -211,7 +211,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down Expand Up @@ -362,7 +362,7 @@ jobs:
- EquinixMetal
- Cloud
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
languages:
Expand Down Expand Up @@ -527,7 +527,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down Expand Up @@ -633,7 +633,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/smoke-test-cli-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
platform:
- ubuntu-latest
source-dir:
Expand Down Expand Up @@ -185,7 +185,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down Expand Up @@ -300,7 +300,7 @@ jobs:
- EquinixMetal
- Cloud
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
languages:
Expand Down Expand Up @@ -444,7 +444,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down Expand Up @@ -548,7 +548,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/smoke-test-provider-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
platform:
- ubuntu-latest
source-dir:
Expand Down Expand Up @@ -185,7 +185,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down Expand Up @@ -293,7 +293,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
languages:
Expand Down Expand Up @@ -437,7 +437,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down Expand Up @@ -541,7 +541,7 @@ jobs:
fail-fast: false
matrix:
dotnetversion:
- 3.1.301
- 6.0.114
goversion:
- 1.19.x
nodeversion:
Expand Down
2 changes: 1 addition & 1 deletion aws-cs-ansible-wordpress/pulumi-ansible-wordpress.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion aws-cs-assume-role/assume-role/assume-role.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion aws-cs-assume-role/create-role/create-role.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion aws-cs-eks/Aws.EksCluster.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion aws-cs-fargate/App/aws-cs-fargate.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<RootNamespace>dotnet_core_tutorial</RootNamespace>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion aws-cs-fargate/Infra/Aws.Fargate.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
<AWSProjectType>Lambda</AWSProjectType>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion aws-cs-lambda/pulumi/Aws.Lambda.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion aws-cs-lambda/pulumi/LambdaStack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public LambdaStack()
var lambda = new Function("basicLambda", new FunctionArgs
{
Runtime = "dotnetcore3.1",
Code = new FileArchive("../DotnetLambda/src/DotnetLambda/bin/Debug/netcoreapp3.1/publish"),
Code = new FileArchive("../DotnetLambda/src/DotnetLambda/bin/Debug/net6.0/publish"),
Handler = "DotnetLambda::DotnetLambda.Function::FunctionHandler",
Role = CreateLambdaRole().Arn
});
Expand Down
17 changes: 16 additions & 1 deletion aws-cs-s3-folder/WebsiteStack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,21 @@ public WebsiteStack()
}
});

var ownershipControls = new BucketOwnershipControls("ownership-controls", new()
{
Bucket = bucket.Id,
Rule = new BucketOwnershipControlsRuleArgs
{
ObjectOwnership = "ObjectWriter",
},
}, new CustomResourceOptions {Parent = bucket});

var publicAccessBlock = new BucketPublicAccessBlock("public-access-block", new()
{
Bucket = bucket.Id,
BlockPublicAcls = false,
}, new CustomResourceOptions {Parent = bucket});

// For each file in wwwroot ...
var files = Directory.GetFiles("wwwroot");
foreach (var file in files)
Expand All @@ -31,7 +46,7 @@ public WebsiteStack()
Bucket = bucket.BucketName,
ContentType = contentType,
Source = new FileAsset(file)
}, new CustomResourceOptions {Parent = bucket});
}, new CustomResourceOptions {Parent = bucket, DependsOn = new Pulumi.Resource[]{ publicAccessBlock, ownershipControls }});
}

this.Endpoint = Output.Format($"http:https://{bucket.WebsiteEndpoint}");
Expand Down
2 changes: 1 addition & 1 deletion aws-cs-s3-folder/aws-cs-s3-folder.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
<RootNamespace>Examples</RootNamespace>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion aws-cs-secrets-manager/aws-cs-secrets-manager.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion aws-cs-webserver/Aws.WebServer.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<DebugType>portable</DebugType>
<OutputType>Exe</OutputType>
<EnableDefaultContentItems>false</EnableDefaultContentItems>
Expand Down
2 changes: 1 addition & 1 deletion aws-fs-lambda-webserver/pulumi/Aws.LambdaWebServer.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion aws-fs-lambda-webserver/pulumi/Program.fs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ let infra () =
"basicLambda",
FunctionArgs(
Runtime = inputUnion2Of2 Pulumi.Aws.Lambda.Runtime.DotnetCore3d1,
Code = input (FileArchive "../LambdaWebServer/bin/Debug/netcoreapp3.1/publish" :> Archive),
Code = input (FileArchive "../LambdaWebServer/bin/Debug/net6.0/publish" :> Archive),
Handler = input "LambdaWebServer::Setup+LambdaEntryPoint::FunctionHandlerAsync",
Role = io lambdaRole.Arn,
Timeout = input 30
Expand Down
18 changes: 16 additions & 2 deletions aws-fs-s3-folder/Program.fs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,21 @@ let infra () =
let bucket =
Bucket("my-bucket",
BucketArgs (Website = input (BucketWebsiteArgs (IndexDocument = input "index.html"))))


let ownershipControls =
BucketOwnershipControls("ownership-controls",
BucketOwnershipControlsArgs
(Bucket = io bucket.Id,
Rule = input (BucketOwnershipControlsRuleArgs(ObjectOwnership = input "ObjectWriter"))),
CustomResourceOptions (Parent = bucket))

let publicAccessBlock =
BucketPublicAccessBlock("public-access-block",
BucketPublicAccessBlockArgs
(Bucket = io bucket.Id,
BlockPublicAcls = input false),
CustomResourceOptions (Parent = bucket))

// For each file in wwwroot ...
let files = Directory.GetFiles "wwwroot"
let bucketObjects =
Expand All @@ -28,7 +42,7 @@ let infra () =
Bucket = io bucket.BucketName,
ContentType = input contentType,
Source = input (FileAsset file :> AssetOrArchive)),
CustomResourceOptions (Parent = bucket)))
CustomResourceOptions (Parent = bucket, DependsOn = inputList [input ownershipControls; input publicAccessBlock])))

// Export the name of the bucket
let endpoint = bucket.WebsiteEndpoint.Apply (sprintf "http:https://%s")
Expand Down
2 changes: 1 addition & 1 deletion aws-fs-s3-folder/aws-cs-s3-folder.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
Loading

0 comments on commit 5a48fdc

Please sign in to comment.