Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the doc strings in the non-plotting modules #882

Merged
merged 26 commits into from
Feb 14, 2021

Conversation

willschlitzer
Copy link
Contributor

As mentioned in #881, this is an update to the doc strings of the non-plotting functions to be standardized according to #631.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the documentation Improvements or additions to documentation label Feb 13, 2021
@willschlitzer willschlitzer added this to the 0.3.0 milestone Feb 13, 2021
@willschlitzer willschlitzer marked this pull request as ready for review February 13, 2021 15:11
pygmt/figure.py Outdated Show resolved Hide resolved
pygmt/x2sys.py Outdated Show resolved Hide resolved
pygmt/src/surface.py Outdated Show resolved Hide resolved
pygmt/figure.py Outdated Show resolved Hide resolved
pygmt/figure.py Outdated Show resolved Hide resolved
pygmt/src/blockmedian.py Outdated Show resolved Hide resolved
pygmt/src/blockmedian.py Show resolved Hide resolved
pygmt/src/grdcut.py Outdated Show resolved Hide resolved
pygmt/src/grdcut.py Outdated Show resolved Hide resolved
pygmt/src/info.py Show resolved Hide resolved
pygmt/src/makecpt.py Show resolved Hide resolved
pygmt/src/makecpt.py Show resolved Hide resolved
pygmt/src/makecpt.py Outdated Show resolved Hide resolved
pygmt/x2sys.py Outdated Show resolved Hide resolved
willschlitzer and others added 2 commits February 14, 2021 07:02
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
@willschlitzer
Copy link
Contributor Author

willschlitzer commented Feb 14, 2021

@meghanrjones @seisman Thank you for the thorough feedback!

@seisman
Copy link
Member

seisman commented Feb 14, 2021

@willschlitzer please try your best to update the documentation following #886

pygmt/figure.py Outdated Show resolved Hide resolved
pygmt/figure.py Outdated Show resolved Hide resolved
pygmt/src/info.py Outdated Show resolved Hide resolved
pygmt/src/info.py Outdated Show resolved Hide resolved
pygmt/src/info.py Outdated Show resolved Hide resolved
pygmt/src/info.py Outdated Show resolved Hide resolved
pygmt/src/info.py Outdated Show resolved Hide resolved
pygmt/src/info.py Outdated Show resolved Hide resolved
pygmt/src/makecpt.py Outdated Show resolved Hide resolved
pygmt/src/makecpt.py Outdated Show resolved Hide resolved
pygmt/src/makecpt.py Outdated Show resolved Hide resolved
pygmt/src/makecpt.py Outdated Show resolved Hide resolved
pygmt/src/makecpt.py Outdated Show resolved Hide resolved
pygmt/src/makecpt.py Outdated Show resolved Hide resolved
pygmt/src/surface.py Outdated Show resolved Hide resolved
pygmt/src/surface.py Outdated Show resolved Hide resolved
pygmt/x2sys.py Outdated Show resolved Hide resolved
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge the documentation improvement into v0.3.0.

@seisman seisman merged commit 529eed7 into master Feb 14, 2021
@seisman seisman deleted the docstring-format-non-plotting branch February 14, 2021 20:59
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…s#882)

* Update docstrings for makecpt.py
* Update docstrings for savefig in figure.py
* Update docstrings for psconvert in figure.py
* Update docstrings in blockmedian.py
* Update docstrings in surface.py
* Update docstrings in grdcut.py
* Update docstrings in grdfilter.py
* Update docstrings in x2sys.py
* Update docstrings for x2sys_cross in x2sys.py
* Update docstrings for info.py
* Update output docstring in info.py
* Update formatting in makecpt.py

Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants