Cut Windows CI build time in half to 15 min #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would update to miniconda version 4.8.3 , which is a pretty significant upgrade for the Github Actions Windows runner still stuck at 4.6.14 (as of 6 September 2020).
weiji14
commented
Sep 5, 2020
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| channels: conda-forge | ||
| miniconda-version: "latest" |
There was a problem hiding this comment.
I think you'll like this @seisman, The Windows conda install step speed up (~24min -> ~8min) comes from just adding this one line! What it does (on Windows) is to update the miniconda version from 4.6.14 to 4.8.3, and this would use a newer/faster conda solver, among other things.
There was a problem hiding this comment.
It also speed up macOS. Perhaps we should also update ci_tests_dev.yaml?
There was a problem hiding this comment.
Not really by much, I think we can do it another time since that’s not really a bottleneck.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Attempt at speeding up Windows builds by updating conda version. For Python 3.6, our current Windows build takes ~31min which is too slow!! Should at least half that time to ~15 minutes to make it more in line with macOS/Linux builds. The bulk of the time (~24min) is spent just installing dependencies using conda, so that will be what this PR will focus on optimizing.
Before
After
TODO:
Towards #584
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.