Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shading to grdview gallery example #506

Merged
merged 11 commits into from
Jul 13, 2020
Merged

Conversation

liamtoney
Copy link
Member

Description of proposed changes

Add shading to the new grdview() example. This requires the bugfix of GMT 6.1.0 and will not work in 6.0.0, so we should probably wait to merge this until v0.2.0 is released — this is more of a bookmark. But it looks awesome:

ackley

This is an improvement on #502. @weiji14 please let me know what inline comments / other improvements we should have as well.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@liamtoney liamtoney added the documentation Improvements or additions to documentation label Jul 7, 2020
@liamtoney liamtoney added this to the 0.2.x milestone Jul 7, 2020
@liamtoney liamtoney self-assigned this Jul 7, 2020
@weiji14 weiji14 added this to To do in Release v0.2.x Jul 9, 2020
@vercel vercel bot temporarily deployed to Preview July 12, 2020 05:15 Inactive
@vercel vercel bot temporarily deployed to Preview July 12, 2020 05:16 Inactive
@vercel vercel bot temporarily deployed to Preview July 12, 2020 05:47 Inactive
pygmt/base_plotting.py Outdated Show resolved Hide resolved
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me, but I remember @weiji14 may want to add some comments in the example?

@weiji14 weiji14 added the scipy-sprint Things to work on during the SciPy sprint! label Jul 12, 2020
@vercel vercel bot temporarily deployed to Preview July 12, 2020 22:39 Inactive
@liamtoney
Copy link
Member Author

@weiji14 so once these statuses pass, I may merge?

@weiji14
Copy link
Member

weiji14 commented Jul 12, 2020

Yes! Just click on the 'Squash and merge' button. You might want to format the commit message a bit, just summarize what was done and leave out things like 'fix typo'.

@liamtoney liamtoney merged commit 0f12972 into master Jul 13, 2020
Release v0.2.x automation moved this from To do to Done Jul 13, 2020
@liamtoney liamtoney deleted the grdview-gallery-shading branch July 13, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation scipy-sprint Things to work on during the SciPy sprint!
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants