Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test NumPy 2.0 in the GMT Tests workflow #3292

Merged
merged 1 commit into from
Jun 18, 2024
Merged

CI: Test NumPy 2.0 in the GMT Tests workflow #3292

merged 1 commit into from
Jun 18, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 18, 2024

Description of proposed changes

Bumps numpy from 1.26 to 2.0. NumPy 2.0.0 was released on 17 Jun 2024.

This is in line with PyGMT's policy on SPEC0 at https://www.pygmt.org/v0.12.0/maintenance.html#dependencies-policy, xref #2863.

Note that the branch protection rules at GenericMappingTools/pygmt/settings/branches will need to be changed to use Python 3.12/Numpy 2.0 instead of Python 3.12/Numpy 1.26 before this Pull Request is merged.

Supersedes #2692

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code

@seisman seisman marked this pull request as ready for review June 18, 2024 05:47
@seisman seisman added the maintenance Boring but important stuff for the core devs label Jun 18, 2024
@seisman seisman added this to the 0.13.0 milestone Jun 18, 2024
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jun 18, 2024
@seisman seisman enabled auto-merge (squash) June 18, 2024 07:43
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was almost too easy for a major version bump!

@seisman seisman merged commit ac44706 into main Jun 18, 2024
18 checks passed
@seisman seisman deleted the numpy2.0 branch June 18, 2024 07:50
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants