Fix a failing test for legacy GMT versions #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiji14
approved these changes
Jun 17, 2024
seisman
added
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
As reported in #2511, GMT 6.5.0 has some known bugs working with 03s remote datasets. So, the values with GMT 6.4.0 should be taken as the correct values.
This PR fixes a value from
-924.5(reported by GMT 6.5) to-923.5(reported by GMT 6.4), so that the test doesn't fail in the GMT Legacy Tests CI (see https://github.com/GenericMappingTools/pygmt/actions/runs/9541097742).The GMT Tests CI is not affected because the test is already marked as xfail for GMT 6.5.