Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ghostscript typo in environment.yml #3113

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Fix ghostscript typo in environment.yml #3113

merged 1 commit into from
Mar 16, 2024

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 16, 2024

Description of proposed changes

Fix ghotscript -> ghostscript.

Patches typo in #3112.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 16, 2024
@weiji14 weiji14 added this to the 0.12.0 milestone Mar 16, 2024
@weiji14 weiji14 self-assigned this Mar 16, 2024
@@ -6,7 +6,7 @@ dependencies:
- python=3.12
# Required dependencies
- gmt=6.5.0
- ghotscript=10.03.0
- ghostscript=10.03.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need to pin ghostscript in environment.yml? This line was added in #3112, but we didn't set any pin for ghostscript before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to pin ghostscript here. Otherwise, new developers may install a different gs version and the tests may fail due to minor changes in gs.

@weiji14 weiji14 changed the title Fix ghostscript typo in enviroment.yml Fix ghostscript typo in environment.yml Mar 16, 2024
@weiji14 weiji14 merged commit bcbbcad into main Mar 16, 2024
6 checks passed
@weiji14 weiji14 deleted the typo-ghostscript branch March 16, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants