Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for using GMT 6.0.0rc1 #311

Merged
merged 3 commits into from
Jun 20, 2019

Conversation

claudiodsf
Copy link
Contributor

Also fixes the error message on incompatible GMT version.

Fixes #310

Also fixes the error message on incompatible GMT version.
@welcome
Copy link

welcome bot commented Jun 19, 2019

💖 Thanks for opening this pull request! 💖

Please make sure you read our contributing guidelines and abide by our code of conduct.

A few things to keep in mind:

  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to do this! 🎉

@leouieda
Copy link
Member

@claudiodsf thanks for trying it out and being on top of this!

@leouieda
Copy link
Member

I'm rerunning the Mac tests to see if the failure was just a glitch.

@leouieda
Copy link
Member

@claudiodsf that was an unrelated error with homebrew being outdated on Travis CI. I pushed a patch to your branch the build should pass now (fingers crossed).

@leouieda leouieda mentioned this pull request Jun 19, 2019
5 tasks
@seisman
Copy link
Member

seisman commented Jun 20, 2019

@leouieda Since 6.0.0rc1 is already released, do you think we should switch to the conda-forge's gmt?

@leouieda
Copy link
Member

@seisman yeah, I'm doing that now. I'm also updating all the setup here to use Azure and build on Windows.

@leouieda
Copy link
Member

I removed the GMT compilation from the Travis builds. I think I'll back a cron job that is allowed to fail on Azure for GMT master later on so we make sure things keep working.

@leouieda leouieda changed the title Fix for GMT 6.0.0rc1 Fixes for using GMT 6.0.0rc1 Jun 20, 2019
@leouieda leouieda merged commit e24879f into GenericMappingTools:master Jun 20, 2019
@welcome
Copy link

welcome bot commented Jun 20, 2019

🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉

Please open a new pull request to add yourself to the AUTHORS.md file. We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@leouieda
Copy link
Member

@claudiodsf thank you for submitting the patch and noticing the problem so quickly! We really appreciate the contribution (keep them coming :). Please feel free to add yourself to the AUTHORS.md file.

weiji14 referenced this pull request in weiji14/pygmt Jun 20, 2019
See if things work on GMT 6.0.0rc1 (#311) and Azure Pipelines (#312).
@claudiodsf
Copy link
Contributor Author

Thanks @leouieda! I'll add myself when I'll made a more significant contribution 😉

weiji14 added a commit to weiji14/deepbedmap that referenced this pull request Jun 20, 2019
Using Generic Mapping Tools (GMT) binaries from conda once more now that 6.0.0rc1 is released at https://github.com/GenericMappingTools/gmt/releases/tag/6.0.0rc1! Basically we're reverting the messy manual GMT compile code in our Dockerfile introduced in ee9df38, so less maintainence cost going forward. See actual changes at GenericMappingTools/gmt@20c95af...6.0.0rc1. The Python conda package had to be updated from 3.6.6 to 3.6.7 because the GMT 6.0.0rc1 conda package requires openssl >=1.1.1a, < 1.1.2a. Also had to update PyGMT (personal fork with grdtrack, see changes at weiji14/pygmt@weiji14:0.0.1a0-36-gb1e7b75...0.0.1a0-40-g29220bd) to include the 6.0.0rc1 version fix by GenericMappingTools/pygmt#311.
@weiji14
Copy link
Member

weiji14 commented Jun 20, 2019

Nice job @claudiodsf! Really appreciate the quick work, it's probably saved me an hour or two of time already today 😃

If you're looking to contribute more, you can take a look at those labelled good-first-issues or help-wanted. Or if there's some GMT function you need that's missing in PyGMT, open up an issue and we can start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with GMT 6.0.0rc1
4 participants