Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctests for the validate_output_table_type function #3098

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 11, 2024

Currently, we are testing the behavior of the output_type/outfile parameters in many wrappers' tests (e.g., the 3 grd2xyz tests removed in #3097, filter1d tests in #3085 and grdvolume tests). Since the output_type/outfile parameters are always checked by the validate_output_table_type function, we should test the validate_output_table_type function instead.

The benefits are:

  • Few tests to run and faster CI
  • We can focus on the core functionality of wrappers rather than worry about the output_type/outfile parameters

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 11, 2024
@seisman seisman added this to the 0.12.0 milestone Mar 11, 2024
@seisman seisman added the needs review This PR has higher priority and needs review. label Mar 11, 2024
pygmt/helpers/validators.py Outdated Show resolved Hide resolved
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 12, 2024
@seisman seisman merged commit 2f598c5 into main Mar 13, 2024
13 of 16 checks passed
@seisman seisman deleted the tests/validate_output_type branch March 13, 2024 05:55
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants