Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.psconvert: Ignore the unrecognized 'metadata' parameter added by pytest-mpl v0.17.0 #3054

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Feb 19, 2024

Address #3043 (comment):

After pinning pandas and xarray with Python 3.10, now we have many failures on macOS/Windows. See https://github.com/GenericMappingTools/pygmt/actions/runs/7946102470/job/21694725831. Need to find out why.

pytest-mpl=0.17.0 now adds a metadata key into our savefig call (added in https://github.com/matplotlib/pytest-mpl/pull/196/files I think), and this is not handled by psconvert. We'll need to ignore that metadata key somehow.

@seisman seisman added the maintenance Boring but important stuff for the core devs label Feb 19, 2024
@seisman seisman added this to the 0.12.0 milestone Feb 19, 2024
@seisman seisman added the needs review This PR has higher priority and needs review. label Feb 19, 2024
@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Feb 19, 2024
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 20, 2024
@seisman seisman merged commit ab39616 into main Feb 20, 2024
18 of 19 checks passed
@seisman seisman deleted the mpl-metadata branch February 20, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants