Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.meca: Fix typo pricipal_axis -> principal_axis #2940

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jan 2, 2024

Description of proposed changes

Corrects a typo in Figure.meca that was introduced in #2576 and affects PyGMT v0.10.0, resulting in an error like GMTInvalidInput: Invalid convention 'pricipal_axis' being raised.

Reported by @yasuit21 at https://twitter.com/yasuit21/status/1724513532312698953#m

Patches #2576

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the bug Something isn't working label Jan 2, 2024
@weiji14 weiji14 added this to the 0.11.0 milestone Jan 2, 2024
@weiji14 weiji14 self-assigned this Jan 2, 2024
@weiji14 weiji14 marked this pull request as ready for review January 2, 2024 04:43
@weiji14 weiji14 enabled auto-merge (squash) January 2, 2024 04:46
@weiji14 weiji14 merged commit 5639f24 into main Jan 2, 2024
22 of 25 checks passed
@weiji14 weiji14 deleted the meca/typo_principal_axis branch January 2, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants