Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence PytestUnknownMarkWarning by setting marker for pytest-benchmark #2912

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Dec 25, 2023

Description of proposed changes

Registering custom marker for pytest-benchmark in pyproject.toml to silence PytestUnknownMarkWarning.

Alternative solution would be to install pytest-benchmark in all the Continuous Integration workflow files.

References:

Patches #2908 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 25, 2023
@weiji14 weiji14 self-assigned this Dec 25, 2023
@seisman seisman added this to the 0.11.0 milestone Dec 25, 2023
Copy link
Member Author

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -160,3 +160,6 @@ max-args=10
[tool.pytest.ini_options]
minversion = "6.0"
addopts = "--verbose --durations=0 --durations-min=0.2 --doctest-modules --mpl --mpl-results-path=results"
markers = [
"benchmark: mark a test with custom benchmark settings.",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiji14 weiji14 marked this pull request as ready for review December 25, 2023 08:13
@weiji14 weiji14 enabled auto-merge (squash) December 25, 2023 08:14
@seisman seisman merged commit ab5d950 into main Dec 25, 2023
20 of 23 checks passed
@seisman seisman deleted the silence-pytest-benchmark-warning branch December 25, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants