Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pytest import inside of skip_if_no function #2891

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Dec 17, 2023

Description of proposed changes

To fix the ModuleNotFoundError: No module named 'pytest' error in the cache_data.yaml GitHub Action that was failing at https://github.com/GenericMappingTools/pygmt/actions/runs/7238500260/job/19719382772#step:5:13

Patches #2883.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

To fix the `ModuleNotFoundError: No module named 'pytest'` error in the cache_data.yaml GitHub Action.
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 17, 2023
@weiji14 weiji14 self-assigned this Dec 17, 2023
@weiji14 weiji14 merged commit d1e8f2f into main Dec 17, 2023
17 checks passed
@weiji14 weiji14 deleted the pytest-in-skip_if_no branch December 17, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants