Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ruff's BLE/ICN/PGH/RSE/TCH/TID/YTT rules #2878

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Enable ruff's BLE/ICN/PGH/RSE/TCH/TID/YTT rules #2878

merged 2 commits into from
Dec 14, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 14, 2023 •
edited

These rules all make sense to our project and there are no violations, so this PR enables them all:

  • BLE: flake8-blind-except
  • ICN: flake8-import-conventions
  • PGH: pygrep-hooks
  • RSE: flake8-raise
  • TCH: flake8-type-checking
  • TID: flake8-tidy-imports
  • YTT: flake8-2020

@seisman seisman changed the title Enable ruff's BLE,ICN,PGH,RSE,TID,YTT rules Enable ruff's BLE/ICN/PGH/RSE/TID/YTT rules Dec 14, 2023
@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Dec 14, 2023
@seisman seisman added this to the 0.11.0 milestone Dec 14, 2023
@seisman seisman mentioned this pull request Dec 14, 2023
Closed
@seisman seisman changed the title Enable ruff's BLE/ICN/PGH/RSE/TID/YTT rules Enable ruff's BLE/ICN/PGH/RSE/TCH/TID/YTT rules Dec 14, 2023
@seisman seisman merged commit b18cc59 into main Dec 14, 2023
15 of 17 checks passed
@seisman seisman deleted the ruff/multiple branch December 14, 2023 22:20
@seisman seisman removed the needs review This PR has higher priority and needs review. label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnefroehlich yvonnefroehlich yvonnefroehlich approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seisman @yvonnefroehlich