Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change create-or-update-comment@v3 parameter reaction-type to reactions #2647

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Aug 29, 2023

Description of proposed changes

Parameter name 'reaction-type' is now 'reactions', see peter-evans/create-or-update-comment#29

Fixes warning on running /format like Unexpected input(s) 'reaction-type', valid inputs are ['token', 'repository', 'issue-number', 'comment-id', 'body', 'body-path', 'body-file', 'edit-mode', 'append-separator', 'reactions', 'reactions-edit-mode'], see e.g. https://github.com/GenericMappingTools/pygmt/actions/runs/6006824531

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Aug 29, 2023
@weiji14 weiji14 self-assigned this Aug 29, 2023
@weiji14 weiji14 marked this pull request as ready for review August 29, 2023 01:36
@michaelgrund michaelgrund added the final review call This PR requires final review and approval from a second reviewer label Aug 29, 2023
@weiji14 weiji14 merged commit 78ad21c into main Aug 29, 2023
8 of 20 checks passed
@weiji14 weiji14 deleted the create-or-update-comment/reactions branch August 29, 2023 09:35
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Aug 29, 2023
@seisman seisman added this to the 0.10.0 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants