Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.colorbar: Add alias for "Q" #2608

Merged
merged 49 commits into from
Jul 21, 2023

Conversation

jhtong33
Copy link
Contributor

Description of proposed changes
As title, the PR aims to add alias "Q" for colorbar

Fixes #2607

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

jhtong33 and others added 30 commits January 11, 2023 12:44
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
@jhtong33
Copy link
Contributor Author

/format

@jhtong33 jhtong33 self-assigned this Jul 18, 2023
@michaelgrund michaelgrund added feature request New feature wanted enhancement Improving an existing feature and removed feature request New feature wanted labels Jul 18, 2023
pygmt/src/colorbar.py Outdated Show resolved Hide resolved
@yvonnefroehlich yvonnefroehlich changed the title pygmt.colorbar: Add alias "Q" Figure.colorbar: Add alias "Q" Jul 18, 2023
pygmt/src/colorbar.py Outdated Show resolved Hide resolved
pygmt/src/colorbar.py Outdated Show resolved Hide resolved
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Michael Grund <[email protected]>
@jhtong33 jhtong33 added this to the 0.10.0 milestone Jul 19, 2023
@jhtong33 jhtong33 added the needs review This PR has higher priority and needs review. label Jul 19, 2023
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jul 20, 2023
@seisman seisman merged commit b32e6d7 into GenericMappingTools:main Jul 21, 2023
12 of 13 checks passed
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jul 21, 2023
@yvonnefroehlich yvonnefroehlich changed the title Figure.colorbar: Add alias "Q" Figure.colorbar: Add alias for "Q" Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding colorbar -Q
6 participants