-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.meca: Expand docstring for the scale parameter #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnefroehlich
added
documentation
Improvements or additions to documentation
skip-changelog
Skip adding Pull Request to changelog
labels
May 30, 2023
11 tasks
yvonnefroehlich
changed the title
WIP: Expand docstring of 'scale' parameter of 'Figure.meca'
WIP: Expand docstring for "scale" of "Figure.meca"
May 30, 2023
yvonnefroehlich
changed the title
WIP: Expand docstring for "scale" of "Figure.meca"
WIP: "Figure.meca": Expand docstring for "scale"
May 31, 2023
yvonnefroehlich
commented
Jun 3, 2023
yvonnefroehlich
changed the title
WIP: "Figure.meca": Expand docstring for "scale"
"Figure.meca": Expand docstring for "scale"
Jun 3, 2023
yvonnefroehlich
added
the
needs review
This PR has higher priority and needs review.
label
Jun 3, 2023
Related to #1466, but I'm not sure if we need a more Pythonic solution. |
seisman
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We can have a more Pythonic Figure.meca
function later if we want.
seisman
changed the title
"Figure.meca": Expand docstring for "scale"
Figure.meca: Expand docstring for the scale parameter
Jun 8, 2023
seisman
added
final review call
This PR requires final review and approval from a second reviewer
and removed
needs review
This PR has higher priority and needs review.
labels
Jun 8, 2023
Ping @GenericMappingTools/pygmt-maintainers to review this PR. |
michaelgrund
approved these changes
Jun 12, 2023
michaelgrund
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR aims to expand the docstring for the
scale
parameter ofpygmt.Figure.meca
.Upstream GMT documentation: https://docs.generic-mapping-tools.org/dev/supplements/seis/meca.html#s
Preview: https://pygmt-dev--2552.org.readthedocs.build/en/2552/api/generated/pygmt.Figure.meca.html
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version